Skip to content

Fix whiplash algorithm when using goals #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2013
Merged

Fix whiplash algorithm when using goals #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/split/algorithms/whiplash.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,26 @@ def self.choose_alternative(experiment)
end

private

def self.arm_guess(participants, completions)
a = [participants, 0].max
b = [participants-completions, 0].max
s = SimpleRandom.new; s.set_seed; s.beta(a+fairness_constant, b+fairness_constant)
end

def self.best_guess(alternatives)
guesses = {}
alternatives.each do |alternative|
guesses[alternative.name] = arm_guess(alternative.participant_count, alternative.completed_count)
alternatives.each do |alternative|
guesses[alternative.name] = arm_guess(alternative.participant_count, alternative.all_completed_count)
end
gmax = guesses.values.max
best = guesses.keys.select {|name| guesses[name] == gmax }
return best.sample
end

def self.fairness_constant
7
end
end
end
end
end