support multiple metrics per experiment #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yeah that makes sense to me, and keeping backwards compatibility is always good 👍 |
andrew
added a commit
that referenced
this pull request
Sep 25, 2014
support multiple metrics per experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows experiments to support multiple "generic conversions" aka metrics. For example, [:add_to_cart, :purchase]. This way, triggering either finished(:add_to_cart) or finished(:purchase) will trigger a conversion on the experiment.
My intended usage is to do finished(:add_to_cart => "add_to_cart") and finished(:purchase => "purchase") in order to track separate goals with metrics. I didn't try to automate it in order to maintain flexibility and backwards compatibility. Same with the name of the hash "metric." I would like to change it to "metrics" but that would break backwards compatibility.
I don't fully understand the original intended use cases for metrics but from my point of view, it seems it should just automatically trigger conversions for a goal of the same name. In a sense, I see metrics as "universal goals" vs "experiment-specific goals."
Does that make sense?