Skip to content

support multiple metrics per experiment #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2014
Merged

support multiple metrics per experiment #260

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f461c89
support multiple metrics per experiment
stevenou Jun 28, 2014
25bff08
bug fix
stevenou Jun 28, 2014
347476a
bug fix
stevenou Jun 28, 2014
3731479
fix to pass spec
stevenou Jun 28, 2014
832cc80
add elb health check to exclusion list
stevenou Jun 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions lib/split/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def bots
'DigitalPersona Fingerprint Software' => 'HP Fingerprint scanner',
'ShowyouBot' => 'Showyou iOS app spider',
'ZyBorg' => 'Zyborg? Hmmm....',
'ELB-HealthChecker' => 'ELB Health Check'
}
end

Expand All @@ -109,10 +110,12 @@ def metrics
@metrics = {}
if self.experiments
self.experiments.each do |key, value|
metric_name = value_for(value, :metric).to_sym rescue nil
if metric_name
@metrics[metric_name] ||= []
@metrics[metric_name] << Split::Experiment.new(key)
metrics = value_for(value, :metric) rescue nil
Array(metrics).each do |metric_name|
if metric_name
@metrics[metric_name.to_sym] ||= []
@metrics[metric_name.to_sym] << Split::Experiment.new(key)
end
end
end
end
Expand Down