Skip to content

[private-methods-in-controllers] prevents split helper-methods to become... #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2015
Merged

[private-methods-in-controllers] prevents split helper-methods to become... #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/split/encapsulated_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,12 @@ module EncapsulatedHelper

class ContextShim
include Split::Helper
public :ab_test, :finished

def initialize(context)
@context = context
end

def ab_user
@ab_user ||= Split::Persistence.adapter.new(@context)
end
Expand Down
3 changes: 1 addition & 2 deletions lib/split/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
module Split
module Helper
module_function

def ab_test(metric_descriptor, control = nil, *alternatives)
begin
Expand Down Expand Up @@ -130,8 +131,6 @@ def active_experiments
return experiment_pairs
end

protected

def normalize_metric(metric_descriptor)
if Hash === metric_descriptor
experiment_name = metric_descriptor.keys.first
Expand Down