Upgrades @spree/sdk to 1.2.1 - #206
Conversation
Strix Security ReviewNo security issues found. Updated for Reviewed by Strix |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe sort dropdown now supports explicit option labels with a translation fallback through a shared helper. Its props typing includes additional sorting state and callback fields. The ChangesSort option labels
SDK dependency update
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/utils/filters.ts`:
- Around line 70-76: Update getSortOptionLabel to distinguish an omitted label
from an explicitly provided empty string by checking option.label against
undefined rather than relying on truthiness. Return any defined option.label,
including "", and only call getSortLabel when the label is undefined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 556b55fe-b476-456b-8df4-0506b9f255ef
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
package.jsonsrc/components/products/filters/SortDropdownContent.tsxsrc/lib/utils/filters.ts
Summary by CodeRabbit
New Features
Bug Fixes
Chores