Skip to content

Upgrades @spree/sdk to 1.2.1 - #206

Merged
damianlegawiec merged 1 commit into
mainfrom
upgrade-spreesdk-1.2.1
Jul 29, 2026
Merged

Upgrades @spree/sdk to 1.2.1#206
damianlegawiec merged 1 commit into
mainfrom
upgrade-spreesdk-1.2.1

Conversation

@ifizza

@ifizza ifizza commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Improved product sorting controls to display custom sort-option labels when available.
    • Added a localized fallback for sorting options without custom labels.
  • Bug Fixes

    • Improved consistency between available sorting options and the labels shown in the sorting menu.
  • Chores

    • Updated the commerce SDK to the latest compatible patch release.

@strix-security

strix-security Bot commented Jul 28, 2026

Copy link
Copy Markdown

Strix Security Review

No security issues found.

Updated for 179822a.


Reviewed by Strix
Re-run review · Configure security review settings

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
storefront Ready Ready Preview, Comment Jul 28, 2026 8:38pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The sort dropdown now supports explicit option labels with a translation fallback through a shared helper. Its props typing includes additional sorting state and callback fields. The @spree/sdk dependency is updated from ^1.2.0 to ^1.2.1.

Changes

Sort option labels

Layer / File(s) Summary
Sort label resolution
src/lib/utils/filters.ts
Adds getSortOptionLabel, preferring an explicit label and falling back to translated ID-based labels.
Sort dropdown integration
src/components/products/filters/SortDropdownContent.tsx
Extends sort option and sorting-state prop types, and renders labels through getSortOptionLabel.

SDK dependency update

Layer / File(s) Summary
SDK version update
package.json
Updates @spree/sdk from ^1.2.0 to ^1.2.1.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: damianlegawiec

Poem

I’m a bunny with labels to show,
Sorting by names wherever they go.
Explicit words hop to the front,
Translations follow with a soft little grunt.
And the SDK gets a fresh carrot too!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary dependency upgrade in the pull request and matches the stated objective.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-spreesdk-1.2.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/lib/utils/filters.ts`:
- Around line 70-76: Update getSortOptionLabel to distinguish an omitted label
from an explicitly provided empty string by checking option.label against
undefined rather than relying on truthiness. Return any defined option.label,
including "", and only call getSortLabel when the label is undefined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 556b55fe-b476-456b-8df4-0506b9f255ef

📥 Commits

Reviewing files that changed from the base of the PR and between 4e3172e and 179822a.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • package.json
  • src/components/products/filters/SortDropdownContent.tsx
  • src/lib/utils/filters.ts

Comment thread src/lib/utils/filters.ts
@ifizza
ifizza requested a review from damianlegawiec July 28, 2026 20:50
@damianlegawiec
damianlegawiec merged commit e1b2cc7 into main Jul 29, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants