INT-1945 Initial Commit - #10
Closed
garyrussell wants to merge 7 commits into
Closed
Conversation
Non-Invasive - only modified files are additions to NS Handlers, Schemas, and Docs. Some refactoring still required.
Non-Invasive - only modified files are additions to NS Handlers, Schemas, and Docs. Some refactoring still required.
Contributor
|
Gary, This looks great. Sorry it took me so long to get around to the review; it actually turned out to be less intense than I expected ;) I made a few minor changes and pushed to my fork: https://github.com/markfisher/spring-integration/tree/INT-1945 Please check that out when you get a chance. I'll plan on merging this tomorrow before the M1 release. A few other comments...
/cc @olegz |
Contributor
Author
markfisher
added a commit
that referenced
this pull request
Sep 2, 2011
dir -> directory polishing INT-1945 (S)FTP Gateway - Initial Implementation
Contributor
|
I made one more commit to change several instances of "dir" to "directory": Then, I merged. |
garyrussell
pushed a commit
that referenced
this pull request
Mar 17, 2015
Fix directory name for sample pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial version currently in use at our customer.
It is non-invasive in that the only modified files are the namespace handlers, schemas, and docs. There is a small amount of code duplication in the gateway from the synchronizing inbound adapter.
This could go in M1 with the TODOs below in M2.
TODO:
Factor out common schema elements
Refactor minor code duplication
Explore RemoteFileTemplate