Skip to content

INT-1945 Initial Commit - #10

Closed
garyrussell wants to merge 7 commits into
spring-projects:masterfrom
garyrussell:INT-1945
Closed

INT-1945 Initial Commit#10
garyrussell wants to merge 7 commits into
spring-projects:masterfrom
garyrussell:INT-1945

Conversation

@garyrussell

Copy link
Copy Markdown
Contributor

This is the initial version currently in use at our customer.

It is non-invasive in that the only modified files are the namespace handlers, schemas, and docs. There is a small amount of code duplication in the gateway from the synchronizing inbound adapter.

This could go in M1 with the TODOs below in M2.

TODO:

Factor out common schema elements
Refactor minor code duplication
Explore RemoteFileTemplate

garyrussell and others added 4 commits August 13, 2011 13:53
Non-Invasive - only modified files are additions to NS Handlers,
Schemas, and Docs. Some refactoring still required.
Non-Invasive - only modified files are additions to NS Handlers,
Schemas, and Docs. Some refactoring still required.
@markfisher

Copy link
Copy Markdown
Contributor

Gary, This looks great. Sorry it took me so long to get around to the review; it actually turned out to be less intense than I expected ;)

I made a few minor changes and pushed to my fork: https://github.com/markfisher/spring-integration/tree/INT-1945

Please check that out when you get a chance. I'll plan on merging this tomorrow before the M1 release.

A few other comments...

  1. I'm definitely looking forward to a RemoteFileTemplate in M2 (maybe even a FileTemplate, as a base class for the remote impl if a distinction is necessary).
  2. I'm wondering if we might want to expand FileHeaders.REMOTE_DIR to FileHeaders.REMOTE_DIRECTORY
    There are some inconsistencies already. For example, FileInfo has getRemoteDir(), and AbstractRemoteFileOutboundGateway has isDir(), but ARFOG also has setLocalDirectory(File localDirectory). I know the underlying SFTP code typically abbreviates "dir", but the commons FTP code seems to be explicit with "directory".
  3. This one's very minor, but I wonder if OPTION_JUST_NAME in AbstractRemoteFileOutboundGateway might be better as OPTION _NAME_ONLY?

/cc @olegz

@garyrussell

Copy link
Copy Markdown
Contributor Author

Thanks for the polishing - my bad c&p in the schema stuff really reiterates we need common schema for these modules.

#2 - I agree we should be consistent.
#3 - I concur - I pushed this change.

markfisher added a commit that referenced this pull request Sep 2, 2011
  dir -> directory
  polishing
  INT-1945 (S)FTP Gateway - Initial Implementation
@markfisher

Copy link
Copy Markdown
Contributor

I made one more commit to change several instances of "dir" to "directory":
754917b

Then, I merged.

@markfisher markfisher closed this Sep 2, 2011
garyrussell pushed a commit that referenced this pull request Mar 17, 2015
Fix directory name for sample pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants