This repository was archived by the owner on Feb 17, 2020. It is now read-only.
Highlight keynote in schedule - #562
Merged
Merged
Conversation
quiro91
suggested changes
Apr 15, 2018
quiro91
left a comment
quiro91
left a comment
Collaborator
There was a problem hiding this comment.
Cool, but shouldn't we change the same label also in the detail view? I think it would be weird to have the real experience level inside. Maybe we could add something like "Level: for all (keynote)"?
Collaborator
Author
|
Good point but this pr is about the schedule. Will do in another PR |
quiro91
approved these changes
Apr 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It's hard to tell what is a keynote in our schedule
Solution
Replace the level information with "keynote" for keynotes.
Test(s) added
No
Screenshots
Paired with
Nobody