Skip to content

Conversation

@Happy0
Copy link
Contributor

@Happy0 Happy0 commented Dec 12, 2018

When hovering over a user's display picture, I think it's more helpful to see their display name rather than their public key. This is probably more friendly to screen readers too.

Old Version

New Version

I'll post on scuttlebutt to see if others share my opinion.

@mmckegg
Copy link
Contributor

mmckegg commented Dec 12, 2018

Not used in Patchwork, so fine by me.

In patchwork there are full hovers that show details like avatar, name, id, mutual friends, and whether you follow.

@christianbundy
Copy link
Contributor

Nice!

I think this is a good change, the only time the ID is useful is when there are multiple feeds with the same name and photo and I'm trying to figure out which feed ID to use in Markdown. Frustrating but rare.

I think my personal preference would be name (@feedId) but I don't feel strongly about this, so if you think name-only is best then I trust your decision.

@Happy0
Copy link
Contributor Author

Happy0 commented Dec 13, 2018

@christianbundy - done =]. This is what it looks like now:

New Version

Note: to use this in patchbay, we'll have to remove the /about/html/link file from patchbay while we bump patchcore (which appears to be what the patchcore version is copied from.)

Copy link
Contributor

@christianbundy christianbundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for it, I think this is great!

@Happy0
Copy link
Contributor Author

Happy0 commented Dec 13, 2018

\o/ well, if you're happy, that's good enough for me =p. We can always revert it later if anyone has objections.

Thanks for the review @christianbundy

@Happy0 Happy0 merged commit f3613c3 into ssbc:master Dec 13, 2018
Happy0 added a commit to ssbc/patchbay that referenced this pull request Dec 13, 2018
over avatars to display the user's display name as well as their ID.

Note: this removes the about/html/link depject module since this is
exposed by patchcore (with the new behaviour.)

ssbc/patchcore#76 (commit f3613c3af31488ec38f9cdd73d0353e7d9a7a559)
@arj03
Copy link
Member

arj03 commented Dec 18, 2018

This is excellent, thanks @Happy0 ❤️

@mixmix
Copy link
Member

mixmix commented Dec 18, 2018

Love this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants