-
Notifications
You must be signed in to change notification settings - Fork 17
Use a user's display name in their about HTML link. #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not used in Patchwork, so fine by me. In patchwork there are full hovers that show details like avatar, name, id, mutual friends, and whether you follow. |
|
Nice! I think this is a good change, the only time the ID is useful is when there are multiple feeds with the same name and photo and I'm trying to figure out which feed ID to use in Markdown. Frustrating but rare. I think my personal preference would be |
|
@christianbundy - done =]. This is what it looks like now: Note: to use this in patchbay, we'll have to remove the |
christianbundy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for it, I think this is great!
|
\o/ well, if you're happy, that's good enough for me =p. We can always revert it later if anyone has objections. Thanks for the review @christianbundy |
over avatars to display the user's display name as well as their ID. Note: this removes the about/html/link depject module since this is exposed by patchcore (with the new behaviour.) ssbc/patchcore#76 (commit f3613c3af31488ec38f9cdd73d0353e7d9a7a559)
|
This is excellent, thanks @Happy0 ❤️ |
|
Love this change! |

When hovering over a user's display picture, I think it's more helpful to see their display name rather than their public key. This is probably more friendly to screen readers too.
I'll post on scuttlebutt to see if others share my opinion.