Show warning when the user is not following anyone, therefore may not…

[Happy0]

… be able to see new content. Fixes #707.

[mmckegg]

Code looks pretty good! Gonna give this a try and see 👍

[mmckegg]

@Happy0

This seems to work! However, the warning could be a bit startling for a new user.

Since this also serves as a welcome message, maybe this should provide links to a getting started guide?

Do you have any thoughts @ahdinosaur?

[Happy0]

haha yes, I agree (with regards to it being startling.)

By the way, I just moved the message under the 'write a public message' box so that it doesn't follow you as you scroll down =p.

I could probably do with a hand with the phrasing of the warning box / a good link to put at the bottom of it, and eh.. less startling styling :P.

[Happy0]

I'll update the pull request with:

• My attempt at less intimidating styling / wording.
• A link to https://www.scuttlebutt.nz/

Let you know when it's updated :P.

[Happy0]

Is this any better? @mmckegg

Front end stuff is not my strength. I'm trying though :P.

The text is less intimidating. Do you think I should maybe go with a 'softer' colour scheme? Like the orange from the boxes on profiles warning you that someone might not be able to see your posts?

[Happy0]

Here's my latest attempt using the same styling for other warning boxes (on profiles):

I'm going to stop spamming now :P.

[ahdinosaur]

👍, i like the iterations @Happy0

[Happy0]

Thanks @ahdinosaur :).

I'm thinking I should add a similar box to channels that the user views too. When I first used patchwork, I wasn't sure if channels were 'more public' or not. I later realised they followed the same friend-of-a-friend model.

I suspect the user who unfollowed the pubs he joined that inspired this change ( %5TXFe2XWKvVOMWCelFF74a3t0OVhPkYi4HGpeMqSlpg=.sha256 ) might have thought he could 'lurk' and just view channels without friending anybody.

Similarly, somebody who was onboarded over LAN will be able to see channels, but if they don't follow anybody they won't see new content on channels when they're off the LAN network.

The channel box would have the text:

'
You are Not Following Anyone.

You will not see any new content in this channel until you follow someone.'
'

Do you think this is worth adding too? (cc: @mmckegg )

[Happy0]

They call me spammy0 ;x

[ahdinosaur]

why is "Following Anyone" capitalized?

[ahdinosaur]

if we want to link directly to the "Getting Started" page, it's now available at: https://scuttlebutt.nz/getting-started.html

[ahdinosaur]

this is mostly repeated from modules/page/html/render/channel.js, is it possible (and desirable) to extract out the similar bits into a common module? same for the mcss, which could be a mixin?

[Happy0]

At the time, and thought that trying to abstract it maybe didn't benefit us much because I'd just be replacing 'when' with another function call. However, now that you mention it, I notice that most of the HTML is shared too.

I guess the explanation of why the warning is being shown 'You won't see new public posts' or 'you won't see new channel posts' can be parameterised, which would make it more worthwhile.

Next time I work on the branch, I'll push something like:

`
function renderWarning(conditionObs, explanation) {
var content =
h('div', {classList: 'NotFollowingAnyoneWarning'}, h('section -notFollowingAnyoneWarning', [
h('h1', i18n('You are not Following Anyone')),
h('p', explanation)),
h('p', [i18n("For help, see the 'Getting Started' guide at "),
h('a', {href: 'https://scuttlebutt.nz/getting-started.html'}, 'https://scuttlebutt.nz/getting-started.html')]
),
]))

  return when(conditionObs, content)

}`
I'll check out the mixin thing you linked me too =].

Cheers for the review :D.

[Happy0]

@ahdinosaur I've created a new module (feed.html.followWarning) for the warning rendering code shared by public.js and channel.js . @mmckegg : let me know if this breaks the naming convention for modules - it was the most appropriate place I could think to put it.

I've also moved the shared code for rendering the warning to a $distance-warning mixin. I'd copied and pasted the css from the profile-header.mcss distance-warning class (as I thought it was thematically fitting, as it's a warning about following distance.)

Do these changes make sense to you?

[mmckegg]

This is looking pretty good @Happy0!

I will review in depth and (hopefully) merge it next time get around to doing some patchwork dev!

Thanks @ahdinosaur for the code reviews!

[Happy0]

Cheers m80

[mmckegg]

Okay, merged! Will be in the next release 🎂

[Happy0]

\o/ :D