Show a warning when the user has no followers #740
Conversation
…ne) to let them know their posts won't be visible to anyone.
mmckegg
left a comment
mmckegg
left a comment
There was a problem hiding this comment.
Looking pretty good. Haven't yet had a chance to try this out though.
Oh, I suggest you run npm test (which runs standard JS) and fix up the formatting issues (there's just a couple)
locales/en.json
Outdated
| "unblocked ": "unblocked ", | ||
| "identified ": "identified " | ||
| "identified ": "identified ", | ||
| "Nobody will be able to see your posts until you have a follower. The easiest way to get a follower is to use a pub invite as the pub will follow you back. If you have already redeemed a pub invite and it has not followed you back, try another pub.": "Nobody will be able to see your posts until you have a follower. The easiest way to get a follower is to use a pub invite as the pub will follow you back. If you have already redeemed a pub invite and it has not followed you back, try another pub.", |
There was a problem hiding this comment.
Looks like there is an unused locale string here.
"Nobody will be able to see your posts until you have a follower. The easiest way to get a follower is to use a pub invite as the pub will follow you back. If you have already redeemed a pub invite and it has not followed you back, try another pub."
There was a problem hiding this comment.
oh, you fixed this just before I commented 👍
|
Thanks @mmckegg =]. I ran 'npm test'. I like that there's a flag to make it try and fix some of the issues for you automatically :D (which I did.) I left the unused variables reported by standard in files I didn't touch as I assume they're there for convenience. |
|
Oh, I forgot to fix the formatting of `
I'll do that later. Goodnight! :) |
|
done =] |
|
Updated the pull request to check 'sync' (indexing has finished) like the recent change for the 'no followers' warning. |
modules/page/html/render/public.js
Outdated
| 'Nobody will be able to see your posts until you have a follower. The easiest way to get a follower is to use a pub invite as the pub will follow you back. If you have already redeemed a pub invite and you see it has not followed you back on your profile, try another pub.' | ||
| ) | ||
|
|
||
| // We only show this if the user has followed someone as the first warning ('you are not followed anyone') |
modules/page/html/render/public.js
Outdated
| } | ||
|
|
||
| function noFollowersWarning () { | ||
| var explanation = i18n( |
There was a problem hiding this comment.
I hope at some point we can start transitioning to const over var. Though not necessarily in this change.
| "minutes": "mins", | ||
| "seconds": "secs", | ||
| "minutes": "minutes", | ||
| "seconds": "seconds", |
There was a problem hiding this comment.
Are these lines related to the purpose of this change?
* An error in the code comments * Use 'const' over let in some functions I introduced.
|
Cheers @hbetts =]. I pushed a new commit. I fixed the code comment you pointed out (well spotted.) I changed
|
Ah. Thank you for the explanation. 😄
I definitely agree with waiting until a later pull request. It's not a change directly related to the goal of this pull request. From what else I can tell, this change looks good to me 👍 |
|
\o/ :D |
| "one": "You follow someone that follows this person.", | ||
| "other": "You follow %s people that follow this person." | ||
| "one": "You follow %s people that follow this person.", | ||
| "other": "You follow %s people that follow this person." |
There was a problem hiding this comment.
I'm not sure why these changes were made. It is overriding the custom strings with default ones. I will attempt to roll these back before merging. Hopefully my git foo is strong enough!!
|
Released as part of Patchwork v3.8.9 🎉 |
|
Yasss :D. |
3 participants
A user's activity (posts, likes, etc) will not be visible to anyone under the following circumstances:
They onboard via a local network by following someone on the network. However, nobody on that network follows them back before they leave the network and open patchwork back up on another network. They can therefore see content, but nobody can see theirs.
They redeem a pub invite, but due to a bug (or the server spontaneously exploding at just the wrong moment, and the key is lost in the wreckage) the pub never follows the user back. This has happened to me and I have seen it happen to at least one friend (a pub invite following the pub, resulting in gossip to download new messages, but the pub not following back.) Luckily, I was able to notice this had happened to my friend and tell them to try another pub.
I plan to investigate the scuttlebot side of this to see if I can work out why this sometimes happens, but I still think it's worth being defensive 'client side' as there may be a regression, a faulty implementation, a spontaneous server explosion, etc.
I think it's worth having a warning message for these situations.
Note: the warning box is only displayed if the user follows someone or a pub, but is not followed back See the code comments for an explanation of why I took this approach.
Does this approach to issues 1 and 2 seem reasonable?
This pull request follows on from #713