Skip to content

Fix terminal URL click fallback#2942

Merged
Jinwoo-H merged 1 commit into
mainfrom
Jinwoo-H/link-click-2
May 27, 2026
Merged

Fix terminal URL click fallback#2942
Jinwoo-H merged 1 commit into
mainfrom
Jinwoo-H/link-click-2

Conversation

@Jinwoo-H

@Jinwoo-H Jinwoo-H commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a direct terminal HTTP URL mouseup fallback for Cmd/Ctrl-clicks when xterm has not established hover link state
  • split OSC and URL link routing out of the oversized terminal link handler module
  • keep file-link fallback behavior separate and avoid double-opening URLs already handled by xterm

Testing

  • pnpm vitest run --config config/vitest.config.ts src/renderer/src/components/terminal-pane/terminal-link-handlers.test.ts src/renderer/src/lib/terminal-links.test.ts
  • pnpm run typecheck:web
  • pnpm exec oxlint src/renderer/src/components/terminal-pane/terminal-link-handlers.ts src/renderer/src/components/terminal-pane/terminal-url-link-hit-testing.ts src/renderer/src/components/terminal-pane/terminal-osc-link-routing.ts src/renderer/src/components/terminal-pane/use-terminal-pane-lifecycle.ts src/renderer/src/components/terminal-pane/terminal-link-handlers.test.ts

Made with Orca 🐋

Co-authored-by: Orca <help@stably.ai>
@Jinwoo-H Jinwoo-H merged commit c43de76 into main May 27, 2026
1 of 2 checks passed
@Jinwoo-H Jinwoo-H deleted the Jinwoo-H/link-click-2 branch May 28, 2026 00:01
thomaszdxsn pushed a commit to thomaszdxsn/orca that referenced this pull request Jun 15, 2026
Co-authored-by: Orca <help@stably.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant