Focus diff comment popover from ref#3333
Merged
nwparker merged 1 commit intoMay 31, 2026
Merged
Conversation
Contributor
Author
|
Risk-down blocked: exact head is not mergeable against current Exact head: Mergeability evidence:
Because the exact PR head cannot be cleanly validated or merged on top of current main, I did not lower the risk label. |
nwparker
force-pushed
the
nwparker/react-perf-diff-comment-popover-focus-ref
branch
from
May 31, 2026 10:37
72c4761 to
2ef3f87
Compare
Contributor
Author
|
Validated and merged. Evidence:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiffCommentPopover.tsx.Validation
pnpm exec oxlint src/renderer/src/components/diff-comments/DiffCommentPopover.tsxpnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/diff-comments/diff-comment-popover-position.test.tspnpm run typecheck:webgit diff --checkorigin/main 911,working 910Risk
Medium. This changes editor/review-note popover focus timing only; it does not change note persistence, diff comment submission, IPC, SSH, runtime ownership, or git-provider behavior.
Risk assessment
Risk: MEDIUM
Historic risk metadata backfill based on the existing
risk:mediumlabel.Risk: medium
Historic risk metadata backfill based on the existing
risk:mediumlabel.