Skip to content

Reorganized LDAP information - #339

Merged
fhennig merged 4 commits into
mainfrom
feat/300-authentication-concept
Jan 12, 2023
Merged

Reorganized LDAP information#339
fhennig merged 4 commits into
mainfrom
feat/300-authentication-concept

Conversation

@fhennig

@fhennig fhennig commented Jan 11, 2023

Copy link
Copy Markdown
Contributor
  • Split some of the AuthenticationClass concept page into a reference page
  • The other part goes into a concepts page
  • removed the OpenLDAP specific stuff in favor of linking the tutorial
  • Replaced Plantuml image with multiple diagrams in both documents
  • linked all files together

@fhennig
fhennig marked this pull request as ready for review January 11, 2023 13:28
@fhennig
fhennig requested a review from a team January 11, 2023 13:40
@adwk67
adwk67 requested review from adwk67 and removed request for a team January 12, 2023 08:19

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor things.

Comment thread modules/concepts/pages/authentication.adoc Outdated
Comment thread modules/concepts/pages/authentication.adoc Outdated
fhennig and others added 2 commits January 12, 2023 11:06
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>
Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.de>

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhennig
fhennig merged commit 454d197 into main Jan 12, 2023
@fhennig
fhennig deleted the feat/300-authentication-concept branch January 12, 2023 10:09
bors Bot pushed a commit to stackabletech/trino-operator that referenced this pull request Jan 12, 2023
# Description

this: stackabletech/documentation#339 should be merged first (ideally)

- removed integration test reference and referenced tutorial instead.
- removed code specifics in favor of lean snippets

Note: the two references to the `home` (main) component will not work until we release the current nightly docs as the new latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants