Skip to content

[Merged by Bors] - Docs: Rewrote sections to reference new LDAP tutorial - #365

Closed
fhennig wants to merge 2 commits into
mainfrom
feat/authentication-docs-update
Closed

[Merged by Bors] - Docs: Rewrote sections to reference new LDAP tutorial#365
fhennig wants to merge 2 commits into
mainfrom
feat/authentication-docs-update

Conversation

@fhennig

@fhennig fhennig commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Description

this: stackabletech/documentation#339 should be merged first (ideally)

  • removed integration test reference and referenced tutorial instead.
  • removed code specifics in favor of lean snippets

Note: the two references to the home (main) component will not work until we release the current nightly docs as the new latest version.

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@fhennig fhennig changed the title Rewrote sections to reference common pages Docs: Rewrote sections to reference new LDAP tutorial Jan 11, 2023
@fhennig
fhennig marked this pull request as ready for review January 11, 2023 15:08
@fhennig
fhennig requested a review from sbernauer January 11, 2023 15:08

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig

fhennig commented Jan 12, 2023

Copy link
Copy Markdown
Contributor Author

bors merge

bors Bot pushed a commit that referenced this pull request Jan 12, 2023
# Description

this: stackabletech/documentation#339 should be merged first (ideally)

- removed integration test reference and referenced tutorial instead.
- removed code specifics in favor of lean snippets

Note: the two references to the `home` (main) component will not work until we release the current nightly docs as the new latest version.
@bors

bors Bot commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Pull request successfully merged into main.

Build succeeded:

@bors bors Bot changed the title Docs: Rewrote sections to reference new LDAP tutorial [Merged by Bors] - Docs: Rewrote sections to reference new LDAP tutorial Jan 12, 2023
@bors bors Bot closed this Jan 12, 2023
@bors
bors Bot deleted the feat/authentication-docs-update branch January 12, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants