Skip to content

chore: Remove product-config and product_config_utils#1252

Merged
siegfriedweber merged 10 commits into
mainfrom
chore/remove-product-config
Jul 22, 2026
Merged

chore: Remove product-config and product_config_utils#1252
siegfriedweber merged 10 commits into
mainfrom
chore/remove-product-config

Conversation

@siegfriedweber

@siegfriedweber siegfriedweber commented Jul 21, 2026

Copy link
Copy Markdown
Member

Description

Remove the dependency to product-config and the product_config_utils module.

In the operators, product_config must be removed from RunArguments.

Part of stackabletech/issues#870

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@siegfriedweber siegfriedweber self-assigned this Jul 21, 2026
Comment thread crates/stackable-operator/src/crd/git_sync/v1alpha1_impl.rs Outdated
Comment thread crates/stackable-operator/src/crd/git_sync/v1alpha2_impl.rs Outdated
@maltesander

Copy link
Copy Markdown
Member

Some greps still show product config references (care some false positives):

grep -r "product config" .
./crates/stackable-operator/src/config_overrides.rs:/// Trait that allows the product config pipeline to extract flat key-value
./crates/stackable-operator/src/config_overrides.rs:    /// the format expected by the product config pipeline.
./crates/stackable-operator/src/role_utils.rs:    /// The `configOverrides` can be used to configure properties in product config files
./crates/stackable-operator/src/crd/authentication/oidc/mod.rs:    /// OIDC specific config options. These are set on the product config level.
./crates/stackable-operator/src/config/mod.rs://! - Apply `#[derive(Fragment)] #[fragment_attrs(derive(Merge))]` for your product configuration (and any of its nested types).
./crates/stackable-operator/src/config/fragment.rs://! Fragments are partially validated parts of a product configuration. For example, mandatory values may be missing.
./crates/stackable-operator/crds/DummyCluster.yaml:                      The `configOverrides` can be used to configure properties in product config files
./crates/stackable-operator/crds/DummyCluster.yaml:                            The `configOverrides` can be used to configure properties in product config files

and

grep -r "product_config" .
./crates/stackable-operator/src/config_overrides.rs:    pub fn as_product_config_overrides(&self) -> BTreeMap<String, Option<String>> {
./crates/stackable-operator/src/config_overrides.rs:    fn key_value_config_overrides_as_product_config_overrides() {
./crates/stackable-operator/src/config_overrides.rs:        let result = kv.as_product_config_overrides();

Some are only changelog related etc.

@siegfriedweber

Copy link
Copy Markdown
Member Author

The product config is still referenced in crates/stackable-operator/src/config_overrides.rs. Rather than adapting this file, I'd prefer to remove all modules that are superseded by their v2 counterparts in a follow-up pull request.

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber
siegfriedweber added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit dff9ff8 Jul 22, 2026
5 checks passed
@siegfriedweber
siegfriedweber deleted the chore/remove-product-config branch July 22, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants