feat(v2): Make ResourceNames::ensure_max_length public - #1260
Open
sbernauer wants to merge 2 commits into
Open
Conversation
20 tasks
Techassi
self-requested a review
August 5, 2026 15:09
siegfriedweber
requested changes
Aug 5, 2026
Comment on lines
+9
to
+10
| /// Maximum length of annotation names | ||
| pub const MAX_ANNOTATION_NAME_LENGTH: usize = 63; |
Member
There was a problem hiding this comment.
This constant belongs in kvp::annotation.
Rather than exposing the value publicly, it might be cleaner to offer a sanitize function that takes a key prefix and name and returns a valid kvp::key::Key.
Comment on lines
+102
to
+106
| pub fn ensure_max_length( | ||
| resource_name: String, | ||
| max_length: usize, | ||
| hash_length: usize, | ||
| ) -> String { |
Member
There was a problem hiding this comment.
This function was written for resource names, where the assertions always hold. If it's now used to shorten arbitrary strings (which could also come from the user) then you can expect the operator to crash.
That said, I do see the usefulness. I'd suggest making it safe for arbitrary strings (which isn't trivial) and moving it to a string utility module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I need this helper function to fix a bug in commons-operator: stackabletech/commons-operator#443
Definition of Done Checklist
Author
Reviewer
Acceptance