Skip to content

Add warning for scraper URL conflicts - #7203

Open
Maista6969 wants to merge 2 commits into
stashapp:developfrom
Maista6969:scraper-url-conflicts
Open

Add warning for scraper URL conflicts#7203
Maista6969 wants to merge 2 commits into
stashapp:developfrom
Maista6969:scraper-url-conflicts

Conversation

@Maista6969

Copy link
Copy Markdown
Contributor

Description

Adds a warning in the Scrapers list in Settings > Metadata Providers when a scraper has a pattern that overlaps with another installed scraper. Clicking the warning icon will open a modal that explains what the issue is and suggests resolving it by uninstalling one of the scrapers, heuristically suggesting that the older one is probably the least useful one. Usually a more recently updated scraper will be more correct, and hopefully that's what the user would want.

Related Issue

This resolves #7200

Testing

Install two scrapers from the Community feed that overlap: right now I've left intentionally overlapping scrapers ATK and ATKGirlfriends in the repository, but I'll fix them when/if this issue is addressed. There are also false positive matches like Reality Kings (which defines the pattern rk.com) and Digital Playground (which defines the pattern digitalplaygroundnetwork.com where the substring rk.com also appears)

Screenshots

Before
image
After
image

This is the warning modal that appears when you click the warning icon
image

Checklist

  • I have read and understood the Contributing document.
  • I have read and understood the AI Usage Policy document.
  • I have made corresponding changes to the documentation (if applicable).

@DogmaDragon

Copy link
Copy Markdown
Collaborator

Could you document in https://github.com/stashapp/stash/blob/develop/ui/v2.5/src/docs/en/Manual/Scraping.md that scraper list can be used in this manner. I feel like unless people know of it, they wouldn't really be able to take advantage of it.

@Maista6969

Copy link
Copy Markdown
Contributor Author

Thanks for the reminder, I've added a few lines where I think they make sense 🙂

@DogmaDragon DogmaDragon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation check passed.

@Gykes Gykes added this to the Version 0.32.0 milestone Sep 4, 2026
@Gykes Gykes added the improvement Something needed tweaking. label Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Something needed tweaking.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Warn about overlapping URL patterns in scrapers

3 participants