Add warning for scraper URL conflicts - #7203
Open
Maista6969 wants to merge 2 commits into
Open
Conversation
Collaborator
|
Could you document in https://github.com/stashapp/stash/blob/develop/ui/v2.5/src/docs/en/Manual/Scraping.md that scraper list can be used in this manner. I feel like unless people know of it, they wouldn't really be able to take advantage of it. |
Contributor
Author
|
Thanks for the reminder, I've added a few lines where I think they make sense 🙂 |
DogmaDragon
approved these changes
Sep 4, 2026
DogmaDragon
left a comment
Collaborator
There was a problem hiding this comment.
Documentation check passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a warning in the
Scraperslist inSettings > Metadata Providerswhen a scraper has a pattern that overlaps with another installed scraper. Clicking the warning icon will open a modal that explains what the issue is and suggests resolving it by uninstalling one of the scrapers, heuristically suggesting that the older one is probably the least useful one. Usually a more recently updated scraper will be more correct, and hopefully that's what the user would want.Related Issue
This resolves #7200
Testing
Install two scrapers from the Community feed that overlap: right now I've left intentionally overlapping scrapers ATK and ATKGirlfriends in the repository, but I'll fix them when/if this issue is addressed. There are also false positive matches like Reality Kings (which defines the pattern
rk.com) and Digital Playground (which defines the patterndigitalplaygroundnetwork.comwhere the substringrk.comalso appears)Screenshots
Before


After
This is the warning modal that appears when you click the warning icon

Checklist