Merged
Conversation
SetPicker was binding global arrow/enter handlers but never cleaned them up if the component was unmounted while open (which happens in Bard after inserting a set). Closes #13806.
jasonvarga
requested changes
Apr 9, 2026
| () => data_get(this.publishContainer.values.value, this.fieldPathPrefix), | ||
| (values) => { | ||
| if (! values) return; | ||
| if (JSON.stringify(values) === JSON.stringify(this.node.attrs.values)) return; |
Member
There was a problem hiding this comment.
What does this have to do with key bindings?
Member
Author
There was a problem hiding this comment.
Nothing directly — it’s an optional guard to skip a no-op updateAttributes call, preventing redundant ProseMirror transactions when set values didn’t actually change. Apparently fewer redundant transactions can reduce weird editor side effects like the undo/history churn.
We can remove it and probably be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetPicker was binding global arrow/enter handlers but never cleaned them up if the component was unmounted while open (which happens in Bard after inserting a set).
Closes #13806.