[6.x] Prevent blueprint field rows from overflowing - #15122
Merged
Conversation
fixes #15117 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where fields in the blueprint/fieldset builder could overflow their card, with the name wrapping onto multiple lines and the width selector and action buttons spilling outside the row.
This was happening because the field row is a flex row where nothing was allowed to shrink. Without
min-w-0on the left-hand side, the name couldn't shrink below its min-content width (so the existingtext-ellipsisnever kicked in), and withoutshrink-0on the right-hand side, the width selector got squashed instead.This PR fixes it by letting the name truncate and keeping the controls at their natural size. On narrow fields (25%), the card is now a container, so the
Fieldlabel next to linked fields is hidden to leave room for the name itself — its tooltip has moved onto the link icon so the reference is still discoverable.Before
After
Fixes #15117