Add a --queue flag to static:warm command - #5272
Conversation
|
All tests succeeding locally. Must be a version thing... |
|
Nah this is no good. I’ll revert the changes later on and target the master branch, which (now) uses high enough versions of Laravel, Guzzle and PHP in its CI. |
…ic-warm-queue # Conflicts: # CHANGELOG.md
|
Well it's passing at least 😅 |
|
Thanks Arthur! I’m wondering though, wouldn’t queueing the warming now implicitly disable the concurrency setting? Maybe we could retain that by instead queueing the warming with just a single warming job, that still uses a pool like when not queueing? |
|
FYI: the goal of the concurrency setting was to lower the amount of simultaneous request when warming the static cache. This eases the load on smaller servers, and prevents the warming from having a lot of requests fail (for example with 504s). My fear is that simply queueing the jobs will overload the smaller servers again, I’d love to queue my static warming in my deploy scripts though. |
|
That sounds correct. If you want to leverage concurrency, don't use the queue option. Another option might be to specify which queue you want to use, and then you can customize it in your |
4 participants
An implementation of idea #750.
This also adds some tests for the static warm command. They are in no way exhaustive, but it is a (good) start.