Antlers Runtime Bugfixes - #5477
Merged
Merged
Conversation
Virtual nodes may sometimes lack these details
Prevents the lexer from scanning to the end of the node and constructing "one giant string value"
If assets is a QueryBuilder instance, there was too much ambiguity inside the processor. This forces the tag to handle it
Apply fixes from StyleCI
Makes modifier parameter logic consistent with Regex Antlers
…de other antlers contexts
…d when fetching data
Both tag pairs and non-pairs will now expect `|` as the modifier parameter separator.
Template developers can now natively escape the `|` character by prefixing it with the `\`:
{{ variable modifier="param_one|param\|two" }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves/makes improvements to a few Antlers Runtime (and related) items:
runtimeparser #5463 - Adds support for yielding the same section within a section, and mimics the current behavior of thisAssetstag will now resolve Builder instances (affected both Regex and Runtime)|on both cases)|when providing multiple parameters to modifiers using array/tag parameter styleArray/Tag Parameter Style Delimiter Changes
Tag pairs and non-tag pairs will both now require the
|character to separate parameters:Non tag-pairs will now require this as well:
Developers may now escape the
|character inside parameters: