Skip to content

[4.x] Fix date filter - #8064

Merged
jasonvarga merged 3 commits into
masterfrom
workaround-date-filter
May 5, 2023
Merged

[4.x] Fix date filter#8064
jasonvarga merged 3 commits into
masterfrom
workaround-date-filter

Conversation

@jasonvarga

Copy link
Copy Markdown
Member

Fixes #8055

The actual issue is that when you clicked a date in the datepicker, since it's not "inside" the filter popover due to it being portaled away, it would think you're clicking away from the filter popover, and close it before the date has a chance to register. (Or something along those lines. 😄)

The real fix is something along the lines of tweaking the clickawayClose logic to ignore clicks inside nested popovers. But it's a bit complicated since they're not actually nested in the DOM.

  • Fix full width inline date pickers. The missing w-full class would prevent the calendars from stretching the full width, even when used as a regular publish field.
  • Use an inline date picker in the filter to workaround the popover issue.
  • make the min width of the field filter popover just a bit wider than a calendar, otherwise it would stick over the edge.

@jasonvarga jasonvarga added the 4.0 label May 5, 2023
@what-the-diff

what-the-diff Bot commented May 5, 2023

Copy link
Copy Markdown
## PR Summary

* **Filter Popover Width Adjustment**
Changed the width of the filter popover to 18rem (minimum width) for improved user experience and readability.
* **RangeInline.vue & SingleInline.vue**
Updates have been made to these files, but specific changes are not mentioned in the PR description. Please consider providing more context or details for better understanding.

@jasonvarga
jasonvarga merged commit 86a3dcf into master May 5, 2023
@jasonvarga
jasonvarga deleted the workaround-date-filter branch May 5, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant