Skip to content

[6.x] Ensure nav customizations apply to breadcrumbs #12460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 3 commits into from
Sep 15, 2025
Merged

[6.x] Ensure nav customizations apply to breadcrumbs #12460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3652bb2
Ensure nav customizations apply to breadcrumbs
duncanmcclean Sep 15, 2025
ad022a7
delete test
duncanmcclean Sep 15, 2025
711d1e9
actually, repurpose instead of deleting
duncanmcclean Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/CP/Breadcrumbs/Breadcrumbs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public static function push(Breadcrumb $breadcrumb)

public static function build(): array
{
$breadcrumbs = Nav::build(preferences: false)->map(function (array $section): ?array {
$breadcrumbs = Nav::build()->map(function (array $section): ?array {
$primaryNavItem = $section['items']->first(function (NavItem $navItem) {
return $navItem->isActive();
});
Expand Down
15 changes: 10 additions & 5 deletions tests/CP/Breadcrumbs/BreadcrumbsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public function it_builds_breadcrumbs_correctly_for_content_show_page()
}

#[Test]
public function it_ignores_nav_preferences_when_building_breadcrumbs()
public function it_uses_nav_preferences_when_building_breadcrumbs()
{
$this->actingAs($user = User::make()->makeSuper())->get(cp_route('dashboard'));

Expand All @@ -125,13 +125,18 @@ public function it_ignores_nav_preferences_when_building_breadcrumbs()

$breadcrumbs = Breadcrumbs::build();

// None of the preferences should be applied to the breadcrumbs.
$this->assertEquals([
new Breadcrumb(
text: 'Dashboard',
text: 'The Dashboard',
url: 'http://localhost/cp/dashboard',
icon: 'dashboard',
links: []
icon: 'browser-com',
links: [
['icon' => 'collections', 'text' => 'Collections', 'url' => 'http://localhost/cp/collections'],
['icon' => 'navigation', 'text' => 'Navigation', 'url' => 'http://localhost/cp/navigation'],
['icon' => 'taxonomies', 'text' => 'Taxonomies', 'url' => 'http://localhost/cp/taxonomies'],
['icon' => 'assets', 'text' => 'Assets', 'url' => 'http://localhost/cp/assets'],
['icon' => 'globals', 'text' => 'Globals', 'url' => 'http://localhost/cp/globals'],
]
),
], $breadcrumbs);
}
Expand Down
Loading