[6.x] Improve Combobox performance#12499
Merged
jasonvarga merged 7 commits intomasterfrom Sep 19, 2025
Merged
Conversation
Member
|
@duncanmcclean Should we look at adding virtualization to address any possible performance concerns in #12475? |
duncanmcclean
changed the title
duncanmcclean
changed the title
Since it relies on browser-specific APIs which we don't have in our tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request attempts to improve the performance of long Comboboxes by implementing Reka's
ComboboxVirtualizercomponent.I haven't been able to figure out how to scroll to the selected option when opening the dropdown, but I'll figure that out later. I've already got an issue open in Linear for it. 👍
This PR also fixes an issue where options would overflow the container, and where icons in the Icon fieldtype would cause layout shift when the icons load in.
Fixes #12475.