[5.x] Avoid replacing nocache regions in initial full-measure response#13953
Merged
jasonvarga merged 6 commits into5.xfrom Feb 18, 2026
Merged
[5.x] Avoid replacing nocache regions in initial full-measure response#13953jasonvarga merged 6 commits into5.xfrom
jasonvarga merged 6 commits into5.xfrom
Conversation
jasonvarga
changed the title
Member
|
I've changed this to be the standard behavior (for full measure). Rather than someone caching something incorrectly and then hunt for a solution/setting once they realized, we should just make it work correctly out of the box. |
jasonvarga
added a commit
that referenced
this pull request
Feb 18, 2026
# Conflicts: # CHANGELOG.md # src/Fieldtypes/Icon.php # tests/StaticCaching/FullMeasureStaticCachingTest.php this also adjusts CsrfTokenReplacer logic because the cleanly merged code from #13953 would've been incorrect.
|
Thanks so much @duncanmcclean and @jasonvarga ! This takes away a pain point for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adjusts full-measure to avoid nocache regions and csrf tokens being replaced in the initial response, allowing CDNs (like Cloudflare) to cache the placeholders and JS code.
Closes #13800