Skip to content

[6.x] Various drag & drop fixes#14219

Merged
jasonvarga merged 2 commits into6.xfrom
drag-and-drop-fixes
Mar 11, 2026
Merged

[6.x] Various drag & drop fixes#14219
jasonvarga merged 2 commits into6.xfrom
drag-and-drop-fixes

Conversation

@duncanmcclean
Copy link
Member

This pull request fixes various drag & drop issues:

  • Fixes Bard sets not being draggable
    • This was happening because our workaround for a Firefox bug ([6.x] Fix Firefox not receiving text selection in nested Bards #14021) set draggable="false" on the node-view-wrapper element, preventing the native dragstart events from firing, which TipTap needs to handle drag and drop.
    • This PR fixes it by adding draggable="true" directly to the drag handle element, allowing the native dragstart event to fire from the handle and bubble up to TipTap's event handler, while the wrapper remains draggable="false" to preserve the Firefox text selection fix.
    • Fixes Can't move set unless its focused within Bard #14191
  • Fixes relationship items not being draggable when going from "0 -> some" items
    • This was happening because makeSortable() is only run when the ref="items" element exists, but it's wrapped inside a v-if which evaluates to false when there aren't any items.
    • I've fixed it by calling makeSortable() when items are added to an empty relationship field.
    • Fixes Can not drag/move linked items up/down #14124

@jasonvarga jasonvarga merged commit c841503 into 6.x Mar 11, 2026
18 checks passed
@jasonvarga jasonvarga deleted the drag-and-drop-fixes branch March 11, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't move set unless its focused within Bard Can not drag/move linked items up/down

2 participants