Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes various drag & drop issues:
draggable="false"on thenode-view-wrapperelement, preventing the nativedragstartevents from firing, which TipTap needs to handle drag and drop.draggable="true"directly to the drag handle element, allowing the nativedragstartevent to fire from the handle and bubble up to TipTap's event handler, while the wrapper remainsdraggable="false"to preserve the Firefox text selection fix.makeSortable()is only run when theref="items"element exists, but it's wrapped inside av-ifwhich evaluates to false when there aren't any items.makeSortable()when items are added to an empty relationship field.