[5.x] Add additional URL::isExternalToApplication() tests#14288
Merged
jasonvarga merged 2 commits into5.xfrom Mar 18, 2026
Merged
[5.x] Add additional URL::isExternalToApplication() tests#14288jasonvarga merged 2 commits into5.xfrom
URL::isExternalToApplication() tests#14288jasonvarga merged 2 commits into5.xfrom
Conversation
jasonvarga
changed the title
URL::isExternalToApplication()URL::isExternalToApplication() tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds additional test cases to the
ProvidesExternalUrlstrait to protect against URL credential injection.The issue only affects the implementation on
6.x, but I thought it was worth adding tests to5.xjust to be sure.Related: #14287