Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reset url parameter of the forgot password endpoint was hardened already in #14008, #14023, #14016, #14287, but this PR goes a step further and prevents it from being manipulatable. Encryption is used now, so you can't just submit whatever you want.
The forgot_password_form tag will automatically encrypt the value which is decrypted on submission.
However, since this endpoint could be used via ajax in the case of a headless site, we can't expect people to use encryption. They wouldn't be able to on the front-end anyway. To preserve backwards compatibility, relative urls can still be provided unencrypted. When an unencrypted absolute URL is used, it "fails" silently and falls back to the built-in password reset URL.
In v7 when we can make a breaking change, we'll get rid of this entirely in favor of a config option.