[6.x] Merge external class attrs through twMerge in UI components#14379
Merged
jasonvarga merged 1 commit into6.xfrom Mar 27, 2026
Merged
[6.x] Merge external class attrs through twMerge in UI components#14379jasonvarga merged 1 commit into6.xfrom
jasonvarga merged 1 commit into6.xfrom
Conversation
Button, Badge, and Toggle/Item now use inheritAttrs: false and pass attrs.class into twMerge so externally-applied Tailwind classes properly override internal ones instead of being concatenated by Vue. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inheritAttrs: falseand routeattrs.classthroughtwMerge, so externally-applied Tailwind classes properly override internal ones instead of being simply concatenated by Vue's default merge strategy.data-*,aria-*, event listeners, etc.) are still passed through viav-bind="restAttrs".Test plan
rounded-noneto<Button>properly overrides the internalrounded-lg<Badge>and<Toggle.Item>similarly override internal classesdata-testid,aria-label) still pass through to the root element🤖 Generated with Claude Code