[6.x] Centralize SVG sanitization and sanitize CSS in style tags#14442
Merged
jasonvarga merged 3 commits into6.xfrom Apr 6, 2026
Merged
[6.x] Centralize SVG sanitization and sanitize CSS in style tags#14442jasonvarga merged 3 commits into6.xfrom
jasonvarga merged 3 commits into6.xfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…anitization, consolidate sanitizeCss tests into data provider Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Statamic\Support\Svg::sanitize(), replacing duplicatedDOMSanitizerusage across four call sites<style>tags within SVGs — strips@importrules and externalurl()references while preserving internal CSS, fragment references (url(#gradient)), and data URIsAssets\Uploader,Assets\Asset,CP\Navigation\NavItem, andTags\Svgto use the centralized method{{ svg }}tag'sallow_tags/allow_attrscustomization continues to work via an optional$sanitizerparameterTest plan
tests/Support/SvgTest.phpcoveringsanitizeCss()and full SVG pipelinetests/Tags/SvgTagTest.phpfor CSS injection via{{ svg }}tag