[6.x] Fix NavBuilder crash when nav item has an unresolved children Closure#14523
Merged
jasonvarga merged 1 commit intostatamic:6.xfrom Apr 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NavBuilder::ensureUrlCachesAreUpToDate()crashes withUndefined property: Closure::$mapwhen a nav item has a children closure that hasn't been resolved yet.Root Cause
resolveChildrenClosures()only resolves children for active items ($item->isActive()). However,ensureUrlCachesAreUpToDate()processes all items in$itemsWithChildrenClosures(filtered byisActive()) and calls$item->children()?->map->url()on them.If an item's children closure wasn't resolved during
resolveChildrenClosures()(e.g. it wasn't active at that point but is now active),$item->children()returns the rawClosure. The null-safe operator?->doesn't help since aClosureis notnull, so accessing->mapon it throwsUndefined property: Closure::$map.Fix
Call
resolveChildren()on each item before accessingchildren()inensureUrlCachesAreUpToDate().resolveChildren()is idempotent — if children are already resolved it returns early.Stack Trace