Skip to content

[6.x] Fix TypeError when asset last_modified meta is null #14530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 3 commits into from
Apr 23, 2026
+17 −1
Merged

[6.x] Fix TypeError when asset last_modified meta is null #14530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad33864
Fix TypeError when asset last_modified meta is null
v-Woody Apr 21, 2026
0db3f69
Fix test to not assert fragile timestamp value
v-Woody Apr 21, 2026
3a7c071
adjust test so it would've actually failed
jasonvarga Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Assets/Asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ public function mimeType()
*/
public function lastModified()
{
return Carbon::createFromTimestamp($this->meta('last_modified'), config('app.timezone'));
return Carbon::createFromTimestamp($this->meta('last_modified') ?? 0, config('app.timezone'));
}

/**
Expand Down
16 changes: 16 additions & 0 deletions tests/Assets/AssetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,22 @@ public function it_gets_last_modified_time()
$this->assertEquals(Carbon::parse('2017-01-02 14:35:00')->timestamp, $lastModified->timestamp);
}

#[Test]
public function it_does_not_throw_when_getting_last_modified_and_file_doesnt_exist()
{
// This is really a workaround for an underlying bug.
// It's odd for an asset to not have a corresponding file.
// Once resolved, this test could be removed, although it doesn't hurt by being here.

Storage::fake('test');
// Intentionally do no not create the actual file.

$asset = (new Asset)->container($this->container)->path('foo/test.txt');

$lastModified = $asset->lastModified();
$this->assertInstanceOf(Carbon::class, $lastModified);
}

#[Test]
public function it_generates_and_clears_meta_caches()
{
Expand Down
Loading