Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/Exceptions/ElevatedSessionAuthorizationException.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Statamic\Exceptions;

use Illuminate\Http\Request;
use Statamic\Facades\URL;
use Statamic\Statamic;

class ElevatedSessionAuthorizationException extends \Exception
Expand All @@ -22,6 +23,21 @@ public function render(Request $request)
? cp_route('confirm-password')
: route('statamic.elevated-session');

return redirect()->setIntendedUrl($request->fullUrl())->to($redirectUrl);
$intendedUrl = $request->isMethod('GET')
? $request->fullUrl()
: $this->refererForIntendedUrl($request);

return redirect()->setIntendedUrl($intendedUrl)->to($redirectUrl);
}

private function refererForIntendedUrl(Request $request)
{
$referer = $request->headers->get('referer');

if ($referer && ! URL::isExternalToApplication($referer)) {
return $referer;
}

return $request->fullUrl();
}
}
56 changes: 56 additions & 0 deletions tests/Auth/ElevatedSessionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,17 @@ protected function resolveApplicationConfiguration($app)
return 'ok';
})->middleware(Middleware\RequireElevatedSession::class);

Route::post('/requires-elevated-session', function () {
return 'ok';
})->middleware(Middleware\RequireElevatedSession::class);

Route::get('/cp/requires-elevated-session', function () {
return 'ok';
})->middleware(Middleware\CP\RequireElevatedSession::class);

Route::post('/cp/requires-elevated-session', function () {
return 'ok';
})->middleware(Middleware\CP\RequireElevatedSession::class);
});
}

Expand Down Expand Up @@ -309,6 +317,54 @@ public function middleware_denies_request_when_elevated_session_has_expired()
->assertRedirect('/cp/auth/confirm-password');
}

#[Test]
public function middleware_uses_referer_as_intended_url_for_post_requests()
{
$this->actingAs($this->user);

$this
->withElevatedSession(now()->subMinutes(16))
->post('/cp/requires-elevated-session', [], ['referer' => 'http://localhost/cp/some-form'])
->assertRedirect('/cp/auth/confirm-password')
->assertSessionHas('url.intended', 'http://localhost/cp/some-form');
}

#[Test]
public function middleware_falls_back_to_full_url_when_referer_is_external_for_post_requests()
{
$this->actingAs($this->user);

$this
->withElevatedSession(now()->subMinutes(16))
->post('/cp/requires-elevated-session', [], ['referer' => 'https://evil.example.com/form'])
->assertRedirect('/cp/auth/confirm-password')
->assertSessionHas('url.intended', 'http://localhost/cp/requires-elevated-session');
}

#[Test]
public function middleware_falls_back_to_full_url_when_referer_is_missing_for_post_requests()
{
$this->actingAs($this->user);

$this
->withElevatedSession(now()->subMinutes(16))
->post('/cp/requires-elevated-session')
->assertRedirect('/cp/auth/confirm-password')
->assertSessionHas('url.intended', 'http://localhost/cp/requires-elevated-session');
}

#[Test]
public function middleware_uses_full_url_as_intended_url_for_get_requests()
{
$this->actingAs($this->user);

$this
->withElevatedSession(now()->subMinutes(16))
->get('/cp/requires-elevated-session', ['referer' => 'http://localhost/cp/some-form'])
->assertRedirect('/cp/auth/confirm-password')
->assertSessionHas('url.intended', 'http://localhost/cp/requires-elevated-session');
}

#[Test]
public function middleware_denies_request_when_elevated_session_has_expired_via_json()
{
Expand Down
Loading