[6.x] Resolve Entries and Assets GraphQL types#14618
Closed
ryanmitchell wants to merge 3 commits into
Closed
Conversation
Member
|
Thanks! This is good, but definitely a breaking change. Gonna close this one but make an internal note to come back to it for v7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found it hard to write a succinct title for this one 🤔
This PR updates the Entries fieldtype to return a EntriesSelectType when specific collections are requested on the field type. It also updates the Assets fieldtype to return an AssetType when a container is specified on the field.
Potentially breaking, but gives better cues to the GraphQL consumer as to what to expect.
Don't feel bad about closing this if you'd prefer to tackle it in a different way.
Closes #12974