[6.x] Fix flaky TracksLastModified file timestamp test#14634
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
it_gets_last_updated_at_from_filetest inTracksLastModifiedTestis intermittently flaky on CI.The entry under test is never saved, so its file doesn't exist on disk. Both
fileLastModified()andlastModified()fall through toCarbon::now(). If the second-tick rolls over between the two calls, the timestamps differ by 1 and the assertion fails (e.g.1778265757vs1778265756).Freezing time at the start of the test pins both calls to the same instant.