[5.x] Fix token path traversal#14700
Merged
Merged
Conversation
Avoids calling Token::find() with an empty or null token value, which would otherwise trigger the path traversal protection and throw an exception.
Reject any token name that isn't strictly [A-Za-z0-9_-] rather than denylisting separators. This covers traversal, absolute paths, and Windows drive/UNC paths in one check, regardless of OS or encoding. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Fail fast at construction instead of silently regenerating, so callers don't end up holding a token whose name differs from what they asked for. find() still returns null for invalid names to avoid an error oracle on attacker-supplied input. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PCRE's $ matches before a trailing newline, which let a token name like "abc\n" pass the allowlist. \z anchors strictly to end of string. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jasonvarga
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents path traversal in token lookups.