[6.x] Fix static cache invalidation stripping trailing slashes#14713
Open
duncanmcclean wants to merge 1 commit into
Open
[6.x] Fix static cache invalidation stripping trailing slashes#14713duncanmcclean wants to merge 1 commit into
duncanmcclean wants to merge 1 commit into
Conversation
When trailing slash enforcement is enabled via `URL::enforceTrailingSlashes()`, custom invalidation rules were failing to clear the cache because the invalidator was explicitly stripping trailing slashes with `withTrailingSlash: false`. This caused a mismatch: the URL index stores paths with trailing slashes (e.g., `/events/`) but the invalidator was generating paths without them (e.g., `/events`), causing exact-match lookups to fail. The fix removes the explicit `withTrailingSlash: false` argument from all `URL::tidy()` calls, allowing them to respect the global trailing slash setting. Fixes #14701 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where static cache invalidation rules fail to clear the cache when trailing slash enforcement is enabled via
URL::enforceTrailingSlashes().This was happening because the
DefaultInvalidatorwas explicitly callingURL::tidy()withwithTrailingSlash: false, which stripped trailing slashes regardless of the global setting. This caused a mismatch: the URL index stores paths with trailing slashes (e.g.,/events/) but the invalidator was generating paths without them (e.g.,/events), causing exact-match lookups to fail.This PR fixes it by removing the explicit
withTrailingSlash: falseargument from allURL::tidy()calls, allowing them to respect the global trailing slash setting. This is consistent with howDefaultUrlExcluderalready handles URL normalization.Fixes #14701