[6.x] Fix TypeError when elevated_session_duration is a string#14771
Merged
Conversation
This test reproduces GitHub issue #14769 where env() returns a string value for STATAMIC_ELEVATED_SESSION_DURATION, causing Carbon's addMinutes() to throw a TypeError. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Cast the config value to int before passing to Carbon's addMinutes(), which requires int|float. This fixes the issue when users configure the value via env() which returns strings. Fixes #14769 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Thanks! just a quick suggestion: using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where setting
STATAMIC_ELEVATED_SESSION_DURATIONviaenv()causes a TypeError.This was happening because
env()returns string values, and Carbon'saddMinutes()method requiresint|float. When a user publishes the config and modifies it to useenv('STATAMIC_ELEVATED_SESSION_DURATION', 15), the string value like'15'would cause:This PR fixes it by casting the config value to
floatbefore passing it toaddMinutes().Fixes #14769