Fix trans_choice() pluralization#3405
Merged
jasonvarga merged 3 commits intomasterfrom Mar 19, 2021
Merged
Conversation
…uld be underscores. They need to be underscores for pluralization to work with Laravel’s `MessageSelector` class.
The locale that gets passed is affected by our middleware change, so it should always have underscores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Laravel's
MessageSelectorrequires locales likede_CHto use underscores, but we were using dashes. This fixes the use oftrans_choice()to pluralize strings in locales likede_CH.Anyone referencing
de-CHwith a dash in their config, will be taken care of by the middleware for backwards compatibility. However, all translations with a dash in their path will need to be updated.