fix(core): error handling and typed query for the per-year contributions fetch - #484
Open
marcalexiei wants to merge 1 commit into
Open
Conversation
|
@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchTotalContributionsreadcontribRes.data.data.userwithout checking for errors.Now follows the standard approach: first error message, wrapped for the card, or a generic
GRAPHQL_ERROR.the new
graphql/contributionsDocument.tsassembles the per-year aliases around...YearContributionsspreads (typed by the fragment instats.graphql).It is sent via
createGraphQLFetcher, the untypedrequestcall and its cast are gone.