fix: update stride validation error messages#11998
Merged
Merged
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
develop commits merged 2026-05-07/2026-05-08blas/ext/base
…kages in `blas/ext/base/slast-index-of-row` https://claude.ai/code/session_011khUcNFhVFVmsnp7Tcp1vR
…kages in `blas/ext/base/glast-index-of-row` https://claude.ai/code/session_011khUcNFhVFVmsnp7Tcp1vR
b73330b to
4cfe7c0
Compare
blas/ext/base
kgryte
reviewed
May 10, 2026
kgryte
reviewed
May 10, 2026
kgryte
reviewed
May 10, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
May 10, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween11fb87da(2026-05-07 13:37 -0500) and5fd5c85c(2026-05-08 16:47 +0500). Two sibling-consistency fixes across recently-addedblas/ext/basepackages:blas/ext/base/slast-index-of-row— The error message inlib/slast_index_of_row.jsandlib/slast_index_of_row.native.js(03cd59e4) lacks the lower bound specification thatsindex-of-rowand sibling packages include; updated both files and their JSDoc@throwstags to use the form'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: \%d`.'with both stride andLDA` parameters.blas/ext/base/glast-index-of-row—7c02336dhas incomplete stride validation messaging inlib/main.js: the runtime throw omits the required lower bound and the@throwstag lacks context. Aligned both the error format string and documentation with the siblinggindex-of-rowimplementation, which provides the full constraintmax(1,N)for auditability.Related Issues
No related issues.
Questions
No.
Other
Validation
What was checked:
blas/ext/basepackages (cwhere,dindex-of-column,slast-index-of-row,glast-index-of-row) and supporting commits, comparing each against established sibling packages.What was deliberately excluded:
ddb2fb7e) and TypeScript declaration auto-updates (cecfaba8,583a8336) — spot-checked only.Note on revisions
An earlier revision of this PR also included a documentation-wording change to
blas/ext/base/dindex-of-column("stride of the" → "stride length for the"). That commit was dropped after maintainer review: the original phrasing already matched the majority sibling convention (dindex-of-row,sindex-of-row,gindex-of-row), so the change was unwarranted.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored end-to-end by Claude Code as part of an automated 24-hour commit-review pass. Findings were produced by parallel reviewer agents, independently re-verified against sibling packages before any edit, and limited to high-signal sibling-consistency fixes. A maintainer should audit before promoting out of draft.
@stdlib-js/reviewers
Generated by Claude Code