Skip to content

fix: update stride validation error messages #11998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 3 commits into from
May 10, 2026
+3 −3
Merged

fix: update stride validation error messages #11998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
304952c
style: align `RangeError` message and `@throws` text with sibling pac…
claude May 8, 2026
4cfe7c0
style: align `RangeError` message and `@throws` text with sibling pac…
claude May 8, 2026
43f03c8
Apply suggestions from code review
kgryte May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/ext/base/glast-index-of-row/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function glastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW )
s = M;
}
if ( LDA < max( 1, s ) ) {
throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) );
}
if ( isColumnMajor( order ) ) {
sa1 = 1;
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function slastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW )
s = M;
}
if ( LDA < max( 1, s ) ) {
throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) );
}
if ( isColumnMajor( order ) ) {
sa1 = 1;
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/ext/base/slast-index-of-row/lib/slast_index_of_row.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function slastIndexOfRow( order, M, N, A, LDA, x, strideX, workspace, strideW )
s = M;
}
if ( LDA < max( 1, s ) ) {
throw new RangeError( format( 'invalid argument. Fifth argument must be a valid stride. Value: `%d`.', LDA ) );
throw new RangeError( format( 'invalid argument. Fifth argument must be greater than or equal to max(1,%d). Value: `%d`.', s, LDA ) );
}
return addon( resolveOrder( order ), M, N, A, LDA, x, strideX, workspace, strideW ); // eslint-disable-line max-len
}
Expand Down