Skip to content

chore: fix JavaScript lint errors#13357

Merged
kgryte merged 2 commits into
stdlib-js:developfrom
ujjwalv01:fix-js-lint-13344
Jul 7, 2026
Merged

chore: fix JavaScript lint errors#13357
kgryte merged 2 commits into
stdlib-js:developfrom
ujjwalv01:fix-js-lint-13344

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Resolves #13344.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes a JSDoc doctest linting failure in @stdlib/regexp/basename by updating the // returns assertion syntax to the non-assertive // e.g., returns syntax for a cross-platform Windows path check.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@ujjwalv01 ujjwalv01 requested a review from a team July 7, 2026 09:33
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Jul 7, 2026
@stdlib-bot

stdlib-bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
regexp/basename $\\color{green}132/132$
$\\color{green}+0.00\\%$
$\\color{green}9/9$
$\\color{green}+0.00\\%$
$\\color{green}1/1$
$\\color{green}+0.00\\%$
$\\color{green}132/132$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Jul 7, 2026
Comment thread lib/node_modules/@stdlib/regexp/basename/lib/index.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. review: 5 labels Jul 7, 2026
@kgryte kgryte changed the title chore: fix JavaScript lint errors (issue #13344) chore: fix JavaScript lint errors Jul 7, 2026
@kgryte kgryte merged commit 09d16f1 into stdlib-js:develop Jul 7, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. review: 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants