test: migrate math/base/special/atanh to ULP-based testing#13646
Merged
Conversation
Replaces relative-tolerance (EPS-scaled delta/tol) fixture comparisons with `isAlmostSameValue` ULP-difference assertions (maxULP=1) in test.js and test.native.js, per #11352.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
marked this pull request as ready for review
July 24, 2026 21:46
kgryte
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
math/base/special/atanhtest fixtures from relative-tolerance (EPS-scaleddelta/tol) comparisons to ULP-difference assertions using@stdlib/assert/is-almost-same-value, per the RFC in [RFC]: Migratemath/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352.test/test.jsandtest/test.native.js.1for all four fixture-based test blocks (negative, positive, small negative, small positive values). Measured minimum required ULP difference across all 8,012 fixture points (2,003 points × 4 fixture sets) was0(exact matches in this environment);1is used as the minimum safe integer bound consistent with the convention used in sibling conversions (e.g.,math/base/special/asinh) to allow for architecture/FMA-related rounding variance. Verified deterministic by running the full test suite twice.±Infinity,±0,NaN, and out-of-domain inputs) were changed.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored autonomously by Claude Code as part of a scheduled automation task, including candidate discovery, the test-file conversion, and ULP-bound measurement. It was opened as a draft for maintainer review.
@stdlib-js/reviewers
Generated by Claude Code