Skip to content

chore: follow-up fixes for commits merged to develop in the last 24 hours#13653

Draft
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-07-25
Draft

chore: follow-up fixes for commits merged to develop in the last 24 hours#13653
Planeshifter wants to merge 3 commits into
developfrom
philipp/fix-commit-review-2026-07-25

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

Follow-up fixes for commits merged to develop between 2026-07-24T14:34:00-07:00 (aef97d0) and 2026-07-25T03:11:20-07:00 (b0882ed). An automated review of that window (12 commits) surfaced the issues below; each was independently re-verified against the diff and the stdlib style guides before being fixed.

This pull request:

ml/base/loss/float64/modified-huber-gradient

  • Fix casing of "huber" → "Huber" in the modified-huber-gradient README intro, matching every other reference in the file (9a8f1f3, lib/node_modules/@stdlib/ml/base/loss/float64/modified-huber-gradient/README.md).
  • Fixes copy-paste slip in lib/node_modules/@stdlib/ml/base/loss/float64/modified-huber-gradient/README.md (from 9a8f1f3) where the x/p NaN examples both had NaN in the y slot, leaving those cases undemonstrated; now mirrors squared-error-gradient with one example per argument plus all-NaN.

stats/base/dists/invgamma/quantile

  • Restore the omitted alpha/beta/p parameter description dropped from the C doxygen summaries in include/stdlib/stats/base/dists/invgamma/quantile.h and src/main.c in 525c0cb, aligning wording with lib/main.js and every other quantile package's C docs.
  • Fixed the leftover description string introduced alongside the 525c0cb rate→scale rename: lib/node_modules/@stdlib/stats/base/dists/invgamma/quantile/test/test.native.js still read "given large rate parameter beta"; updated to "scale parameter" to match the corrected shape/scale parameterization.
  • Fixed unspaced array indices (p[i], alpha[i], beta[i], expected[i]) introduced in 525c0cb's test/test.native.js for stats/base/dists/invgamma/quantile, bringing them in line with the adjacent expected[ i ]/p[ i ] usages per the style guide's spaced-array-index rule.

stats/base/dists/anglit/pdf

  • Fix unspaced array-index and call-padding style violations (x[i]x[ i ], etc.) in the stats/base/dists/anglit/pdf tests introduced by 72cc422, across test/test.factory.js, test/test.main.js, and test/test.native.js.

Related Issues

Does this pull request have any related issues?

No related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation performed:

  • Style-guide compliance audit of all 12 commits in the window (two independent passes against docs/style-guides, comparing new packages against mature reference packages).
  • Bug scan of the union diff (two independent passes), including numeric verification of documented example values, JS↔C implementation parity for the new native code, and fixture validation — no runtime bugs found; the items above are docs/style only.
  • All modified JS files pass node --check; changes are limited to comments, docs, test description strings, and whitespace (no behavioral changes).

Deliberately excluded (to keep this PR high-signal):

  • Anything requiring interpretation or judgment (e.g. the σ <= 0 README wording in anglit/pdf matches the established anglit/cdf convention, so it was left alone; likewise the test.main.js naming, which is shared by several existing packages).
  • Findings that failed independent re-verification (e.g. a reported "unused EPS require" in the atanh test migration is in fact still used).
  • Anything outside the 24-hour diff window.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was produced by a scheduled Claude Code review of the last 24 hours of commits merged to develop. Claude identified, verified, and applied all fixes; a human maintainer will audit before promoting the PR out of draft.


Generated by Claude Code

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ml/base/loss/float64/modified-huber-gradient $\\color{green}215/215$
$\\color{green}+100.00\\%$
$\\color{green}15/15$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}215/215$
$\\color{green}+100.00\\%$
stats/base/dists/anglit/pdf $\\color{green}319/319$
$\\color{green}+100.00\\%$
$\\color{green}25/25$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}319/319$
$\\color{green}+100.00\\%$
stats/base/dists/invgamma/quantile $\\color{green}307/307$
$\\color{green}+100.00\\%$
$\\color{green}24/24$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}307/307$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants