test: migrate math/base/special/csc to ULP-based assertions - #13828
Conversation
Replaces the EPS-based relative tolerance assertions with `@stdlib/assert/is-almost-same-value` ULP-difference assertions, tightened to the minimum required ULP per fixture range: - huge (negative/positive): 2 ULP - very large (negative/positive): 1 ULP - large/medium/small/smaller/tiny: exact (plain `strictEqual`) Resolves a part of #11352. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MeLecApUxretH11SrzxudS
|
Hello! 👋 We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm! Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks. Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀 For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Resolves a part of #11352.
Description
This pull request:
math/base/special/csctesting from EPS-based relative tolerance assertions to@stdlib/assert/is-almost-same-valueULP difference assertions.huge_negative/huge_positive: 2 ULPvery_large_negative/very_large_positive: 1 ULPlarge,medium,small,smaller,tiny(negative/positive): exact match (0ULP), so these now use plaint.strictEqual, matching the convention used in already-migrated sibling packages (e.g.coth,havercos) for ranges that never require tolerance.test.native.js, keeping the same ULP bounds astest.js.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code, run as a scheduled/autonomous task. It studied issue #11352 and several already-merged sibling PRs (
coth,tanh,besselj0) to mirror the settled idiom, then measured the minimum passing ULP bound per fixture range directly against the implementation.@stdlib-js/reviewers
Generated by Claude Code