Skip to content

bench: update benchmarks to use decimal literals - #13849

Merged
kgryte merged 1 commit into
stdlib-js:developfrom
anandkaranubc:bench/uniform-decimal-literals
Aug 1, 2026
Merged

bench: update benchmarks to use decimal literals#13849
kgryte merged 1 commit into
stdlib-js:developfrom
anandkaranubc:bench/uniform-decimal-literals

Conversation

@anandkaranubc

@anandkaranubc anandkaranubc commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • updates benchmarks across blas/ext/base, stats/array, stats/strided, stats/base, and math/base to use decimal literals when generating random decimal values via @stdlib/random/array/uniform (e.g., uniform( len, -100, 100, options ) => uniform( len, -100.0, 100.0, options )). Decimal values out, decimal values in.

This follows up on review feedback in #13845 (comment). Only benchmark files requiring the continuous @stdlib/random/array/uniform generator were updated; discreteUniform usage (integer values out, integer values in) was intentionally left unchanged.

Related Issues

Does this pull request have any related issues?

stdlib-js/metr-issue-tracker#1098

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The change was applied mechanically and verified: all 453 updated files bind uniform to @stdlib/random/array/uniform, the diff contains only uniform( len, ... ) range-argument literal changes, and no examples, tests, or source files were modified.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

Used Claude Code to scan for affected files and apply the mechanical literal updates.


@stdlib-js/reviewers

Decimal values out, decimal values in. When generating random decimal
values via `@stdlib/random/array/uniform`, range arguments should be
decimal literals.
@anandkaranubc
anandkaranubc requested a review from a team August 1, 2026 22:36
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 1, 2026
@anandkaranubc anandkaranubc added Benchmarks Pull requests adding or improving benchmarks for measuring performance. METR Pull request associated with the METR project. labels Aug 1, 2026
@anandkaranubc

Copy link
Copy Markdown
Contributor Author

So many changes but the diff contains nothing but those literal changes only. 😅

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Aug 1, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the clean-up!

@kgryte

kgryte commented Aug 1, 2026

Copy link
Copy Markdown
Member

I'll go ahead and merge this on the assumption that CI should either pass or fail for expected reasons.

@kgryte
kgryte merged commit 22fe7a6 into stdlib-js:develop Aug 1, 2026
70 of 73 checks passed
@anandkaranubc
anandkaranubc deleted the bench/uniform-decimal-literals branch August 1, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. METR Pull request associated with the METR project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants