test: migrate math/base/special/roundn to ULP-based assertions - #13857
Merged
Conversation
Resolves a part of #11352. Replaces the manual `delta <= tol` relative-tolerance check in the subnormal-rounding test with `@stdlib/assert/is-almost-same-value` using a ULP budget of 1, mirroring the migrations already merged for the sibling `truncn` and `floorb` packages.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Aug 2, 2026
kgryte
reviewed
Aug 2, 2026
kgryte
reviewed
Aug 2, 2026
kgryte
reviewed
Aug 2, 2026
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>
kgryte
marked this pull request as ready for review
August 2, 2026 10:03
kgryte
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
@stdlib/math/base/special/roundnfrom relative tolerance testing to ULP-based difference testing, utilizing@stdlib/assert/is-almost-same-value.Only one test block (rounding very small/subnormal numbers) used the old
delta <= tolidiom; it has been replaced withisAlmostSameValue( v, expected[ i ], ULP )using a namedULPconstant, mirroring the conventions used in the already-mergedmath/base/special/truncn(#13784) andmath/base/special/floorb(#12786) migrations, which are the closest sibling packages (same rounding-family test structure).Measured minimum ULP bound:
ULP = 1(tightened from an initial high value;ULP = 0fails 5 of the 17 subnormal-rounding cases). The full test suite (350 assertions) was run twice atULP = 1to confirm deterministic behavior.Only the test files were changed; no new external dependency was introduced (
@stdlib/assert/is-almost-same-valueis a monorepo-internal package resolved the same way as in the prior-art PRs, so nopackage.jsonchange was needed).Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code (Anthropic), running as an unattended scheduled agent. It searched the repository for the relative-tolerance testing idiom described in #11352, checked for existing open/merged conversion PRs to avoid duplicating work, studied the prior-art commits for
truncnandfloorb, converted the tests, ran the suite locally to find the tightest ULP bound, and ran ESLint against the changed files.@stdlib-js/reviewers
Generated by Claude Code