fix: pass const qualified views - #14052
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQ3tFyqhydxb2Fp34o5oUE
…sumkbn` Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQ3tFyqhydxb2Fp34o5oUE
…ce types Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UQ3tFyqhydxb2Fp34o5oUE
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
August 8, 2026 12:55
kgryte
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-08-07 15:36 PT (ccacbf9) and 2026-08-08 03:51 PT (b56e927).This pull request:
stats/base/ndarray/smean:src/addon.cinsmeanpassed non-constarraysstraight tostdlib_stats_smean(), which takesconst struct ndarray *arrays[];struct ndarray **doesn't implicitly convert toconst struct ndarray **, so it broke under-Wincompatible-pointer-types(error by default on GCC>=14/Clang>=16). Introduced in 5ca7350; fixed by adding the const-qualified viewarr, matching smeankbn2/smeanli/dmediansorted from the same window.blas/ext/base/ndarray/snansumkbn: Fix-Wincompatible-pointer-typesinndarray/snansumkbn/src/addon.c(introduced in 5b355d1): build aconst struct ndarray *arr[ 1 ] = { arrays[ 0 ] };view before callingstdlib_blas_ext_snansumkbn(), matching the pattern used by sibling addons.blas/ext/base: Fixblas/ext/baseTS declarations: 268ae62 addeddtril2triuto the namespacelib/index.js, but 31eafd1's declaration update missed it —docs/types/index.d.tslacked both theimport dtril2triu = require(...)line and thedtril2triu: typeof dtril2triu;interface member, sons.dtril2triufailed TS2339 despite existing at runtime. Added both, alphabetically ordered, JSDoc ported from the package's owndocs/types/index.d.tswith examples rewritten tons.form.Related Issues
No.
Questions
No.
Other
Validation. The 35 commits merged to
developin the window were reviewed by four independent review passes: two auditing stdlib style-guide compliance (docs/style-guides) against established reference packages, and two scanning for bugs/security/logic errors in the introduced code. Findings were merged, de-duplicated, and each surviving issue was re-verified directly against the working tree (header prototypes checked for const qualification; namespacelib/index.jscross-checked againstdocs/types/index.d.ts). Deliberately excluded: subjective suggestions, style preferences not mandated by the style guides, and anything requiring interpretation or changes outside the window's diff. No other issues survived filtering.This PR is a draft for maintainer audit; each fix is a separate commit grouped by package.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored end-to-end by Claude Code as part of an automated 24-hour commit-review routine: AI agents reviewed the window's diffs, validated findings against the working tree, and applied the fixes. A human maintainer will audit before promoting from draft.
Generated by Claude Code