feat: add stats/strided/snanmeankbn by AryanSharma48 · Pull Request #14175 · stdlib-js/stdlib

AryanSharma48 · 2026-08-11T18:37:15Z

Resolves #13955

Description

What is the purpose of this pull request?

This pull request:

Adds @stdlib/stats/strided/snanmeankbn, implementing single-precision NaN-ignoring strided mean calculation using Kahan-Babuška-Neumaier (KBN) compensated summation.
Inlines the KBN summation loop in src/main.c and lib/ndarray.js to perform single-pass sum computation while dynamically filtering NaN values and tracking valid count ($n$).
Adds edge-case safeguards returning NaN when $n = 0$ (all elements are NaN or $N \le 0$).
Implements C public headers, TypeScript declarations, and comprehensive unit tests verifying $1\text{D}$, ndarray, and negative stride behavior.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

[RFC]: add missing single precision nan modules for stats/strided #13955

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted an AI assistant to verify stdlib C header guard conventions, edge cases, and contribution workflows, but the code implementation, stride logic, and test verifications were reviewed and authored manually by myself.

@stdlib-js/reviewers

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>

stdlib-bot · 2026-08-11T18:37:26Z

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Please read our contributing guidelines if you haven't already.
For development guidance, refer to the development guide.

Next Steps

A project maintainer will approve GitHub Actions workflows for your PR.
All CI checks must pass before your submission can be fully reviewed.
You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>

This fixes an issue where the native test cases were asserting invalid return values instead of expecting NaNs to be properly ignored, aligning them with the pure JS tests so all tests pass in the C-build. Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>

0PrashantYadav0

Make all the changes I have suggested.

0PrashantYadav0 · 2026-08-12T06:29:24Z

+*/
+interface Routine {
+	/**
+	* Computes the arithmetic mean of a single-precision floating-point strided array using an improved Kahan–Babuška algorithm.


Suggested change

* Computes the arithmetic mean of a single-precision floating-point strided array using an improved Kahan–Babuška algorithm.

* Computes the arithmetic mean of a single-precision floating-point strided array, ignoring `NaN` values and using an improved Kahan–Babuška algorithm.

0PrashantYadav0 · 2026-08-12T06:29:37Z

+	* @example
+	* var Float32Array = require( '@stdlib/array/float32' );
+	*
+	* var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );


Suggested change

* var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );

* var x = new Float32Array( [ 1.0, -2.0, NaN, 2.0 ] );

0PrashantYadav0 · 2026-08-12T06:29:49Z

+	( N: number, x: Float32Array, strideX: number ): number;
+
+	/**
+	* Computes the arithmetic mean of a single-precision floating-point strided array using an improved Kahan–Babuška algorithm and alternative indexing semantics.


Suggested change

* Computes the arithmetic mean of a single-precision floating-point strided array using an improved Kahan–Babuška algorithm and alternative indexing semantics.

* Computes the arithmetic mean of a single-precision floating-point strided array, ignoring `NaN` values and using an improved Kahan–Babuška algorithm and alternative indexing semantics.

0PrashantYadav0 · 2026-08-12T06:30:03Z

+	* @example
+	* var Float32Array = require( '@stdlib/array/float32' );
+	*
+	* var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );


Suggested change

* var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );

* var x = new Float32Array( [ 1.0, -2.0, NaN, 2.0 ] );

0PrashantYadav0 · 2026-08-12T06:30:13Z

+}
+
+/**
+* Computes the arithmetic mean of a single-precision floating-point strided array using an improved Kahan–Babuška algorithm.


Suggested change

* Computes the arithmetic mean of a single-precision floating-point strided array using an improved Kahan–Babuška algorithm.

* Computes the arithmetic mean of a single-precision floating-point strided array, ignoring `NaN` values and using an improved Kahan–Babuška algorithm.

0PrashantYadav0 · 2026-08-12T07:06:13Z

+
+## See Also
+
+-   <span class="package-name">[`@stdlib/stats/strided/dmeankbn`][@stdlib/stats/strided/dmeankbn]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a double-precision floating-point strided array using an improved Kahan–Babuška algorithm.</span>


Suggested change

- [`@stdlib/stats/strided/dmeankbn`][@stdlib/stats/strided/dmeankbn]: calculate the arithmetic mean of a double-precision floating-point strided array using an improved Kahan–Babuška algorithm.

- [`@stdlib/stats/strided/smeankbn`][@stdlib/stats/strided/smeankbn]: calculate the arithmetic mean of a single-precision floating-point strided array using an improved Kahan–Babuška algorithm.

0PrashantYadav0 · 2026-08-12T07:06:24Z

+## See Also
+
+-   <span class="package-name">[`@stdlib/stats/strided/dmeankbn`][@stdlib/stats/strided/dmeankbn]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a double-precision floating-point strided array using an improved Kahan–Babuška algorithm.</span>
+-   <span class="package-name">[`@stdlib/stats/strided/meankbn`][@stdlib/stats/strided/meankbn]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a strided array using an improved Kahan–Babuška algorithm.</span>


Suggested change

- [`@stdlib/stats/strided/meankbn`][@stdlib/stats/strided/meankbn]: calculate the arithmetic mean of a strided array using an improved Kahan–Babuška algorithm.

- [`@stdlib/stats/strided/snanmean`][@stdlib/stats/strided/snanmean]: calculate the arithmetic mean of a single-precision floating-point strided array, ignoring NaN values.

0PrashantYadav0 · 2026-08-12T07:06:42Z

+
+-   <span class="package-name">[`@stdlib/stats/strided/dmeankbn`][@stdlib/stats/strided/dmeankbn]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a double-precision floating-point strided array using an improved Kahan–Babuška algorithm.</span>
+-   <span class="package-name">[`@stdlib/stats/strided/meankbn`][@stdlib/stats/strided/meankbn]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a strided array using an improved Kahan–Babuška algorithm.</span>
+-   <span class="package-name">[`@stdlib/stats/strided/smean`][@stdlib/stats/strided/smean]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a single-precision floating-point strided array.</span>


Suggested change

- [`@stdlib/stats/strided/smean`][@stdlib/stats/strided/smean]: calculate the arithmetic mean of a single-precision floating-point strided array.

- [`@stdlib/stats/strided/snanmeanors`][@stdlib/stats/strided/snanmeanors]: calculate the arithmetic mean of a single-precision floating-point strided array, ignoring NaN values and using ordinary recursive summation.

0PrashantYadav0 · 2026-08-12T07:07:01Z

+
+[@stdlib/stats/strided/dmeankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/dmeankbn
+
+[@stdlib/stats/strided/meankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/meankbn


Suggested change

[@stdlib/stats/strided/meankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/meankbn

[@stdlib/stats/strided/smeankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/smeankbn

0PrashantYadav0 · 2026-08-12T07:07:18Z

+
+[@stdlib/stats/strided/meankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/meankbn
+
+[@stdlib/stats/strided/smean]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/smean


Suggested change

[@stdlib/stats/strided/smean]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/smean

[@stdlib/stats/strided/snanmean]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/snanmean

[@stdlib/stats/strided/snanmeanors]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/snanmeanors

0PrashantYadav0

Make all the changes I have suggested.

AryanSharma48 · 2026-08-12T14:12:01Z

Thanks for the detailed review @0PrashantYadav0 ! I've addressed all the review feedback across the files, updated the style formatting, and resolved the CI check failures. Local tests and linters are passing cleanly now. It's ready for another look when you have a moment!

stdlib-bot · 2026-08-12T14:13:13Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/strided/snanmeankbn	$\\color{green}398/398$ $\\color{green}+0.00\\%$	$\\color{green}25/25$ $\\color{green}+0.00\\%$	$\\color{green}4/4$ $\\color{green}+0.00\\%$	$\\color{green}398/398$ $\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

- Update C function signatures and parameter naming according to project conventions - Align header includes and standard type definitions - Fix linting errors and formatting inconsistencies across strided math implementation - Resolve build and test runner CI failures Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>

0PrashantYadav0 · 2026-08-12T17:08:58Z

Hey! @AryanSharma48 Please take another look at the review—it seems like a couple of the suggested changes slipped through. (I find it helpful to resolve the comments one by one as I apply them so I don't lose track).

Also, let's avoid force-pushing. Before you start working on the remaining changes, make sure to pull/fetch the latest updates from your branch. Let me know if you run into any issues!

feat: add stats/strided/snanmeankbn

617604d

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>

stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Aug 11, 2026

AryanSharma48 mentioned this pull request Aug 11, 2026

[RFC]: add missing single precision nan modules for stats/strided #13955

Open

40 tasks

AryanSharma48 marked this pull request as ready for review August 11, 2026 20:14

AryanSharma48 requested a review from a team August 11, 2026 20:14

stdlib-bot added the Needs Review A pull request which needs code review. label Aug 11, 2026

AryanSharma48 added 2 commits August 12, 2026 02:11

fix: add is-nanf dependency to manifest.json

cc27d6c

Signed-off-by: Aryan Sharma <aryansharma24106@gmail.com>

stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Aug 12, 2026

0PrashantYadav0 suggested changes Aug 12, 2026

View reviewed changes

0PrashantYadav0 added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 12, 2026

AryanSharma48 force-pushed the feat/stats-strided-snanmeankbn branch from 1e3a746 to 34da390 Compare August 12, 2026 14:10

AryanSharma48 force-pushed the feat/stats-strided-snanmeankbn branch from 34da390 to 421cb9b Compare August 12, 2026 14:26

Merge branch 'develop' into feat/stats-strided-snanmeankbn

53b8634

	* Computes the arithmetic mean of a single-precision floating-point strided array using an improved Kahan–Babuška algorithm.
	* Computes the arithmetic mean of a single-precision floating-point strided array, ignoring `NaN` values and using an improved Kahan–Babuška algorithm.

	* var x = new Float32Array( [ 1.0, -2.0, 2.0 ] );
	* var x = new Float32Array( [ 1.0, -2.0, NaN, 2.0 ] );


		## See Also

		- <span class="package-name">[`@stdlib/stats/strided/dmeankbn`][@stdlib/stats/strided/dmeankbn]</span><span class="delimiter">: </span><span class="description">calculate the arithmetic mean of a double-precision floating-point strided array using an improved Kahan–Babuška algorithm.</span>


		[@stdlib/stats/strided/dmeankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/dmeankbn

		[@stdlib/stats/strided/meankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/meankbn

	[@stdlib/stats/strided/meankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/meankbn
	[@stdlib/stats/strided/smeankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/smeankbn


		[@stdlib/stats/strided/meankbn]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/meankbn

		[@stdlib/stats/strided/smean]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/smean

-[@stdlib/stats/strided/smean]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/smean
+[@stdlib/stats/strided/snanmean]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/snanmean
+[@stdlib/stats/strided/snanmeanors]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/stats/strided/snanmeanors

Uh oh!

Uh oh!

Conversation

AryanSharma48 commented Aug 11, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Aug 11, 2026

Getting Started

Next Steps

Running Tests Locally

Documentation Links

Uh oh!

0PrashantYadav0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0PrashantYadav0 left a comment

Choose a reason for hiding this comment

Uh oh!

AryanSharma48 commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stdlib-bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

0PrashantYadav0 commented Aug 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AryanSharma48 commented Aug 12, 2026 •

edited

Loading

stdlib-bot commented Aug 12, 2026 •

edited

Loading